Skip to content

Improve type hints for send_file and send_from_directory #4026

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
davidism merged 1 commit into from
May 13, 2021
Merged

Improve type hints for send_file and send_from_directory #4026

davidism merged 1 commit into from
May 13, 2021

Conversation

@greyli
Copy link
Contributor

@greyli greyli commented May 12, 2021 •
edited by davidism
Loading

  • Add missing type hints for send_file params.
  • Improve type hints for send_from_directory params.

fixes #4044

@greyli greyli force-pushed the improve-type-hints branch from 1246814 to 97eedf1 Compare May 12, 2021 15:07
@greyli greyli marked this pull request as ready for review May 12, 2021 15:15
@davidism davidism added this to the 2.0.1 milestone May 12, 2021
@davidism davidism force-pushed the improve-type-hints branch from 97eedf1 to 80601c5 Compare May 12, 2021 18:13
@davidism davidism changed the base branch from main to 2.0.x May 12, 2021 18:14
@davidism davidism force-pushed the improve-type-hints branch from 80601c5 to d5aadba Compare May 13, 2021 20:33
@davidism davidism merged commit d8c37f4 into pallets:2.0.x May 13, 2021
@greyli greyli deleted the improve-type-hints branch May 14, 2021 00:16
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

typing

Projects

None yet

Milestone

2.0.1

Development

Successfully merging this pull request may close these issues.

2 participants

@greyli @davidism