Skip to content

Conversation

@fantix
Copy link
Contributor

@fantix fantix commented Apr 16, 2019

Entering a client preserves all context from being poped, but exiting only poped one preserved context. This PR pops all preserved context.

@davidism davidism force-pushed the fix-test-client-teardown branch from 39e1210 to 5b97002 Compare May 25, 2019 21:02
@davidism davidism added this to the 1.1.0 milestone May 25, 2019
@davidism davidism force-pushed the fix-test-client-teardown branch from 5b97002 to a71c167 Compare May 25, 2019 21:03
@davidism davidism merged commit 2c68f86 into pallets:master May 25, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 14, 2020
@davidism
Copy link
Member

davidism commented Jul 1, 2022

This was not actually a bug. stream_with_context preserves a context independently of with client, the context should remain until the stream ends or is closed. Either reading response.data or calling response.close() would be the correct fix to the linked issue.

reverted as part of #4666

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Testing errors when streaming

2 participants