Skip to content

Allow customizing url map class #3069

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
davidism merged 1 commit into from
May 19, 2019
Merged

Allow customizing url map class #3069

davidism merged 1 commit into from
May 19, 2019

Conversation

@shidenggui
Copy link
Contributor

@shidenggui shidenggui commented Jan 8, 2019

For speeding up url route matching, I defined a custom rule class and a custom url map class. But Flask currently only allows modifying url rule class, it should support modify url map class too.

    #: The rule object to use for URL rules created.  This is used by
    #: :meth:`add_url_rule`.  Defaults to :class:`werkzeug.routing.Rule`.
    #:
    #: .. versionadded:: 0.7
    url_rule_class = Rule

@ThiefMaster
Copy link
Member

ThiefMaster commented Jan 8, 2019

FYI, your commit isn't properly linked to your GitHub account (different email).

@davidism davidism added this to the 1.1.0 milestone May 19, 2019
@davidism davidism force-pushed the feature_allow_customizing_url_map branch from 1dbbc1a to 2a2a11b Compare May 19, 2019 04:51
@davidism davidism merged commit 05102f6 into pallets:master May 19, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@ThiefMaster ThiefMaster ThiefMaster approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

1.1.0

Development

Successfully merging this pull request may close these issues.

4 participants

@shidenggui @ThiefMaster @davidism @miguelgrinberg