Skip to content

Add example for virtualenv integration in cli docs #2234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
davidism merged 3 commits into from
Apr 7, 2017
Merged

Add example for virtualenv integration in cli docs #2234

davidism merged 3 commits into from
Apr 7, 2017

Conversation

@greyli
Copy link
Contributor

@greyli greyli commented Apr 7, 2017

No description provided.

@greyli greyli changed the title Add example for virtualenv integration in cli Add example for virtualenv integration in cli docs Apr 7, 2017
@untitaker
Copy link
Contributor

untitaker commented Apr 7, 2017

Editing activate scripts is not a good idea, it is like editing code in site-packages.

@untitaker untitaker closed this Apr 7, 2017
@greyli
Copy link
Contributor Author

greyli commented Apr 7, 2017

Thanks. This part Virtualenv Integration was already in docs, is it better to remove it?

@untitaker untitaker reopened this Apr 7, 2017
@untitaker
Copy link
Contributor

untitaker commented Apr 7, 2017

I see, I wasn't aware of that section.

untitaker
untitaker reviewed Apr 7, 2017
View reviewed changes
Copy link
Contributor

@untitaker untitaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I'll just merge this since apparently we already recommend. Personally I'm not a fan of the idea.

docs/cli.rst Outdated
bottom of the file. That way every time you activate your virtualenv you
automatically also activate the correct application name.

You need to edit the specific activate script for different shell, for example:

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

@untitaker untitaker mentioned this pull request Apr 7, 2017
Closed
davidism
davidism reviewed Apr 7, 2017
View reviewed changes
docs/cli.rst Outdated

Unix Bash: ``venv/bin/activate``::

FLASK_APP=foo.py

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

davidism
davidism reviewed Apr 7, 2017
View reviewed changes
docs/cli.rst
Unix Bash: ``venv/bin/activate``::

FLASK_APP=hello
export FLASK_APP

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

@davidism davidism merged commit ec18fe9 into pallets:master Apr 7, 2017
@greyli greyli deleted the patch-3 branch April 7, 2017 14:11
@untitaker
Copy link
Contributor

untitaker commented Apr 7, 2017

Thanks @greyli 🎉

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@davidism davidism davidism approved these changes

+1 more reviewer

@untitaker untitaker untitaker left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@greyli @untitaker @davidism