Use recwarn everywhere #1878
Merged
Use recwarn everywhere #1878
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tests/conftest.py
Outdated
| warnings.simplefilter('default', category=DeprecationWarning) | ||
| return lambda: warnings.catch_warnings(record=True) | ||
| @pytest.fixture(autouse=True) | ||
| def catch_deprecation_warnings(recwarn, request): |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Contributor
Author
|
@ThiefMaster @davidism Please review. |
...instead of custom fixture. Also assert that no warnings are left over after the test.
Contributor
Author
|
Interesting, we're getting a ResourceWarning somewhere. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...instead of custom fixture. Also assert that no warnings are left over
after the test.