Revert "Revert "Don't use threads in this test"" #1407
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I have no idea why this fails, I thought it'd be a fairly straightforward change. Anybody? |
Closed
Member
|
What's the history/status of this? Why did it need to be reverted? Did those other two referenced issues effect it? |
Contributor
Author
|
It's a refactor that I thought was completely trivial, but for some reason it breaks CI, so I postponed it indefinetly. On 31 October 2015 04:55:55 CET, David Lord notifications@github.com wrote:
Sent from my phone. Please excuse my brevity. |
Contributor
Author
|
I don't care about this anymore. IIRC either variant is fine, so who really cares? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 1577e13.