Skip to content

show correct auto complete value for nargs option in combination with flag option#2816

Merged
Rowlando13 merged 8 commits intopallets:stablefrom
eccenca:bugfix/OptionsAutoCompletion
Aug 7, 2025
Merged

show correct auto complete value for nargs option in combination with flag option#2816
Rowlando13 merged 8 commits intopallets:stablefrom
eccenca:bugfix/OptionsAutoCompletion

Conversation

@msaipraneeth
Copy link
Copy Markdown
Contributor

@msaipraneeth msaipraneeth commented Dec 5, 2024

This pull request resolves an issue in the autocompletion logic for options with nargs > 1 when combined with boolean options. Previously, autocompletion would suggest incorrect values, leading to confusion and an inconsistent user experience.

fixes #2813

  • Add tests that demonstrate the correct behavior of the change. Tests
    should fail without the change.
  • Add or update relevant docs, in the docs folder and in code.
  • Add an entry in CHANGES.rst summarizing the change and linking to the issue.

@AndreasBackx AndreasBackx changed the base branch from stable to main December 22, 2024 21:00
@AndreasBackx AndreasBackx changed the base branch from main to stable December 22, 2024 21:03
@AndreasBackx AndreasBackx changed the base branch from stable to main December 22, 2024 21:12
@msaipraneeth msaipraneeth force-pushed the bugfix/OptionsAutoCompletion branch from f68161b to c9e86aa Compare January 22, 2025 08:16
@msaipraneeth msaipraneeth changed the base branch from main to stable January 22, 2025 08:35
@msaipraneeth msaipraneeth force-pushed the bugfix/OptionsAutoCompletion branch from c9e86aa to 71cec9c Compare January 22, 2025 08:41
@msaipraneeth msaipraneeth changed the base branch from stable to main January 22, 2025 08:46
@msaipraneeth msaipraneeth force-pushed the bugfix/OptionsAutoCompletion branch from 71cec9c to 952899e Compare January 22, 2025 08:49
@msaipraneeth msaipraneeth changed the base branch from main to release-8.2.0 January 22, 2025 08:55
@msaipraneeth msaipraneeth changed the base branch from release-8.2.0 to stable January 22, 2025 08:59
@msaipraneeth msaipraneeth changed the base branch from stable to main January 22, 2025 08:59
@msaipraneeth
Copy link
Copy Markdown
Contributor Author

@AndreasBackx Have we selected the correct bash branch for this PR?

@Rowlando13
Copy link
Copy Markdown
Collaborator

@msaipraneeth Please rebase onto stable. Thanks for your patience with changing the branch a lot.

@Rowlando13 Rowlando13 added the bug label Aug 6, 2025
@msaipraneeth msaipraneeth changed the base branch from main to stable August 6, 2025 16:26
@msaipraneeth msaipraneeth force-pushed the bugfix/OptionsAutoCompletion branch from 1e4b807 to 7fc3771 Compare August 6, 2025 16:55
@msaipraneeth
Copy link
Copy Markdown
Contributor Author

@msaipraneeth Please rebase onto stable. Thanks for your patience with changing the branch a lot.

@Rowlando13 Rebased onto the stable branch.
I don't see an Unreleased section in CHANGES.rst. Where should I add the update?

@Rowlando13
Copy link
Copy Markdown
Collaborator

Just make an unreleased section at the top and add it.

@msaipraneeth
Copy link
Copy Markdown
Contributor Author

Just make an unreleased section at the top and add it.

@Rowlando13 Done with the changes. PR is ready for review.

@Rowlando13 Rowlando13 merged commit 4f936ac into pallets:stable Aug 7, 2025
10 checks passed
@msaipraneeth msaipraneeth deleted the bugfix/OptionsAutoCompletion branch August 7, 2025 06:06
@kdeldycke kdeldycke added this to the 8.2.3 milestone Aug 12, 2025
@Rowlando13 Rowlando13 modified the milestones: 8.2.3, 8.3.0 Aug 24, 2025
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 8, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

_is_incomplete_option incorrectly processes last_option in loop

3 participants