More robust check of bash version#2639
Merged
AndreasBackx merged 6 commits intopallets:stablefrom Nov 9, 2024
Merged
Conversation
Contributor
Author
|
Would appreciate some feedback if this is not considered completed. As mentioned, automated testing of this is very context specific, so not sure how, or if, this should be added. Regarding tox test, tox actually fails locally on my mac, but in a completely unrelated section. NOTE: this also fails in My branch has the same test result as main. |
Specifically on windows with git-bash, where python is the normal windows python install Also use `--norc` flag to avoid recursively loading .bashrc (which can happen when the click completion loading does not work properly)
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
db0a63f to
c36f7bb
Compare
eb00003 to
6b18fec
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
More robust check of bash version.
Specifically on windows with git-bash, where python is the normal windows python install
Also use
--norcflag to avoid recursively loading .bashrc (which can happen when the click completion loading does not work properly)Testing should not require any additional tests, but rather make sure to run the existing shell completion tests on multiple platforms, eg Linux, Mac, Windows. Or how do you otherwise recommend adding tests for this?
Checklist:
CHANGES.rstsummarizing the change and linking to the issue... versionchanged::entries in any relevant code docs.pre-commithooks and fix any issues.pytestandtox, no tests failed.