Conversation
6 tasks
co-authored-by: Amethyst Reese <amethyst@n7.gg>
Member
Author
|
OK, I did find #2247, which is essentially the same as this PR, and we closed that in favor of the error because it seemed like |
6 tasks
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#2246 reported that
multiple=Truedidn't work with flags sincedefault=()was also required. I can't remember the original conversation around that, but instead of setting the default, #2248 mademultiple=Truewith flags an error. Comments on the PR, as well as #2292 and #2295 reported that this broke valid uses.This removes the error and instead sets
default=()ifmultiple=Truefor flags. This works if the option is a flag due to a secondary token (-y/-n),is_flag=True, orflag_value=value.fixes #2246
fixes #2292
fixes #2295