Skip to content

Fix typing on command and group decorators#2256

Merged
davidism merged 1 commit intopallets:8.1.xfrom
Jonxslays:patch/typing-fix
Apr 26, 2022
Merged

Fix typing on command and group decorators#2256
davidism merged 1 commit intopallets:8.1.xfrom
Jonxslays:patch/typing-fix

Conversation

@Jonxslays
Copy link
Copy Markdown
Contributor

This PR adds generics to the typing.Callable type hint inside the command and group decorators.

Checklist:

  • Add tests that demonstrate the correct behavior of the change. Tests should fail without the change.
  • Add or update relevant docs, in the docs folder and in code.
  • Add an entry in CHANGES.rst summarizing the change and linking to the issue.
  • Add .. versionchanged:: entries in any relevant code docs.
  • Run pre-commit hooks and fix any issues.
  • Run pytest and tox, no tests failed.

@davidism davidism linked an issue Apr 24, 2022 that may be closed by this pull request
@davidism davidism added this to the 8.1.3 milestone Apr 24, 2022
@davidism davidism merged commit afdfb12 into pallets:8.1.x Apr 26, 2022
@Jonxslays Jonxslays deleted the patch/typing-fix branch April 26, 2022 14:43
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

command and group decorators are untyped on strict

2 participants