changed version_option default package from pkg_resources to importli…#1582
Conversation
|
I removed a couple of no longer needed variables and imports. |
option() returns a decorator, no need for inner decorator function optional package_name parameter to skip stack frame detection package_name is available in message format use nonlocal keyword for modifying args from callback only detect version if package name was detected show error if importlib_metadata needs to be installed show error if detected package name isn't an installed package name show detected package name in error when version wasn't detected rewrite docs
|
Squashed the original commits, added a changelog, added a change to
Also noticed that the change you made changed how the version was being detected, from looking at entry points to looking at the package name directly. It looks like the values returned by The previous implementation tried to find the program name among the |
Co-authored-by: Claudio Jolowicz <claudio.jolowicz@cyren.com>
|
Incorporated #1531 for better version detection when using |
I believe this should close issue #1488