Revert "Use shlex.quote for quoting shell arguments"#1543
Merged
Conversation
This reverts commit e798f64. This caused issues if the editor command (etc.) had options like "less -FRSX" because they would then get quoted as a single word.
This was referenced Apr 27, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This caused issues if the pager/editor command had options like
less -FRSX, they would then get quoted as a single word rather thanlessthen-FRSX.shlex.quotedoesn't seem to do the right thing on Windows cmd. Usingshlex.spliton the command first wouldn't help, as it would need to get re-joined andsubprocess.list2cmdlineis not an external API. Let's hold off until #1476 instead.Reverts #1470
Closes #1514