Fix jsx-key can't detect error in parenthesized expression#181
Merged
adidahiya merged 2 commits intopalantir:masterfrom Mar 12, 2019
Merged
Fix jsx-key can't detect error in parenthesized expression#181adidahiya merged 2 commits intopalantir:masterfrom
adidahiya merged 2 commits intopalantir:masterfrom
Conversation
Member
|
Thanks for your interest in palantir/tslint-react, @lukyth! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request. |
d8205b3 to
aeba27e
Compare
|
Could really use this!! |
Contributor
Author
|
Anything I can do to get this merged? |
adidahiya
approved these changes
Mar 12, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #187
The current implementation miss the case where an arrow function returns
(); i.e.It should be the following code instead.