Add options to allow HTML entities and/or punctuation to be excluded from translation check#139
Merged
adidahiya merged 3 commits intopalantir:masterfrom Feb 12, 2018
EmpaticoOrg:translation-allow-punctuation-htmlentities
Merged
Add options to allow HTML entities and/or punctuation to be excluded from translation check#139adidahiya merged 3 commits intopalantir:masterfrom EmpaticoOrg:translation-allow-punctuation-htmlentities
adidahiya merged 3 commits intopalantir:masterfrom
EmpaticoOrg:translation-allow-punctuation-htmlentities
Conversation
Member
|
Thanks for your interest in palantir/tslint-react, @praxxis! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request. |
Contributor
Author
|
fixes #119 |
Contributor
|
@praxxis can you enable CI for your fork please? https://circleci.com/projects |
Contributor
Author
|
@adidahiya I've enabled CI and it's passing |
added 2 commits
January 19, 2018 10:18
…from translation check This will allow, for example, ` ` to be the contents of an element.
Contributor
Author
|
@adidahiya is anything else I need to do to get this merged? |
|
@adidahiya we'd love to see this merged as its blocking a couple of things! Thanks muchly. 👍 💚 |
adidahiya
approved these changes
Feb 12, 2018
Contributor
adidahiya
left a comment
There was a problem hiding this comment.
I made a small tweak to the rule metadata (it's not typescript-only, I'd consider this a "functionality" rule)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will allow, for example,
to be the contents of an element.This also unifies the way "text" is checked for across all types of elements/attributes.