Cleanup Gradle build#997
Conversation
|
Thanks for your interest in palantir/palantir-java-format, @shanman190! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request. |
| pluginClasspath sourceSets.main.output | ||
| compileOnly configurations.implicitDependencies | ||
| implicitDependencies 'com.diffplug.spotless:spotless-plugin-gradle' | ||
| pluginClasspath 'com.diffplug.spotless:spotless-plugin-gradle' |
There was a problem hiding this comment.
If you'd like to only see com.diffplug.spotless:spotless-plugin-gradle only defined once, a quick way to achieve this is by modifying the pluginClasspath configuration above to have an extendsFrom compileOnly.
fawind
left a comment
There was a problem hiding this comment.
Looks good! Thanks a bunch for the clean up!
|
@shanman190 Thank you again for the work.
I see that there is an early version of the 2.0 version of the plugin (https://plugins.jetbrains.com/docs/intellij/tools-intellij-platform-gradle-plugin-dependencies-extension.html). Can this be used in this project somehow? |
|
@koppor, it might. If this project is ok with the early access version, then I don't see any harm in trying it out though to prove that it does work. |
Before this PR
The build was using some old patterns that aren't supported anymore preventing Gradle 8.x adoption.
After this PR
Possible downsides?
None.