Merged
Conversation
|
👍 I believe truth is coming from google-java-format which this repo is forked from, it's their own assertion library iirc. Don't see anything wrong with getting rid of truth here |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this PR
This repo has been failing Upgrade Dependencies excavator for almost 2 years (since Feb 29, 2024). https://github.com/palantir/palantir-java-format/pulls?q=is%3Apr+%22Excavator%3A+Upgrade+dependencies%22+ . It's gone through a series of PRs that it opened and closed in that time. This is the current one - #1473
The reason (I think) is that it uses a library called com.google.truth:truth for an assertThat and there are (possibly) multiple versions of it. Why we use this library and also use assertj, I don't know. I've removed uses of truth to hopefully unblock other things.
And yes, I did get dark amusement out of the subject of this PR.
After this PR
==COMMIT_MSG==
==COMMIT_MSG==
Possible downsides?