Merged
Conversation
|
|
Member
|
@MischaFrank The PR looks good. We can not set the default to 24 yet, because we havent tested it across all node buildpacks so we are not 100% sure that it works. So one change I would suggest is to set the default to 22. |
Member
|
Thank you for reopening :) |
Member
|
You need a CLA to submit a PR |
Member
|
For the CLA, probably your company might be able to provide you one |
8067c0a to
2aa984f
Compare
Contributor
Author
|
@pacostas Thanks for fast responses. I created the dependencies by hand. Is there an automated process or has it to be done manually? |
2aa984f to
570071b
Compare
Member
|
@MischaFrank There is not an automated process, I usually checkout out the node-engine repo, I add the following snippet on buildpack.toml file [[metadata.dependency-constraints]]
constraint = "24.*"
id = "node"
patches = 2and then I do |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds node 24.x to dependencies in the buildpack.toml as it is the Active LTS version.
Closes #1354
Checklist