Skip to content

feat: add node24#1356

Merged
pacostas merged 1 commit intopaketo-buildpacks:mainfrom
MischaFrank:feat/add_node24
Nov 4, 2025
Merged

feat: add node24#1356
pacostas merged 1 commit intopaketo-buildpacks:mainfrom
MischaFrank:feat/add_node24

Conversation

@MischaFrank
Copy link
Contributor

Summary

Adds node 24.x to dependencies in the buildpack.toml as it is the Active LTS version.

Closes #1354

Checklist

  • I have viewed, signed, and submitted the Contributor License Agreement.
  • I have linked issue(s) that this PR should close using keywords or the Github UI (See docs)
  • I have added an integration test, if necessary.
  • I have reviewed the styleguide for guidance on my code quality.
  • I'm happy with the commit history on this PR (I have rebased/squashed as needed).

@MischaFrank MischaFrank requested a review from a team as a code owner November 4, 2025 12:15
@MischaFrank MischaFrank requested review from mhdawson and pacostas and removed request for a team November 4, 2025 12:15
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Nov 4, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: MischaFrank / name: Mischa (570071b)

@MischaFrank MischaFrank closed this Nov 4, 2025
@pacostas
Copy link
Member

pacostas commented Nov 4, 2025

@MischaFrank The PR looks good. We can not set the default to 24 yet, because we havent tested it across all node buildpacks so we are not 100% sure that it works. So one change I would suggest is to set the default to 22.

@MischaFrank MischaFrank reopened this Nov 4, 2025
@pacostas
Copy link
Member

pacostas commented Nov 4, 2025

Thank you for reopening :)

@pacostas
Copy link
Member

pacostas commented Nov 4, 2025

You need a CLA to submit a PR

@pacostas pacostas added the semver:minor A change requiring a minor version bump label Nov 4, 2025
@pacostas
Copy link
Member

pacostas commented Nov 4, 2025

For the CLA, probably your company might be able to provide you one

Copy link
Member

@pacostas pacostas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome ! LGTM

@MischaFrank
Copy link
Contributor Author

@pacostas Thanks for fast responses. I created the dependencies by hand. Is there an automated process or has it to be done manually?

@pacostas
Copy link
Member

pacostas commented Nov 4, 2025

@MischaFrank There is not an automated process, I usually checkout out the node-engine repo,

I add the following snippet on buildpack.toml file

  [[metadata.dependency-constraints]]
    constraint = "24.*"
    id = "node"
    patches = 2

and then I do

cd dependency
make retrieve buildpackTomlPath=./../../buildpack.toml output="metadata.json" 
../.bin/jam update-dependencies --buildpack-file ../buildpack.toml --metadata-file ./retrieval/metadata.json

@pacostas pacostas merged commit 3fb923c into paketo-buildpacks:main Nov 4, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

semver:minor A change requiring a minor version bump

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Node 24

2 participants