spec(crux-ship-001): require classifier + CLI wiring + e2e in same PR#985
Merged
Conversation
Adds `shipping_discipline:` section to contracts/crux-competitive-research-ux-v1.yaml
codifying CRUX-SHIP-001: every CRUX PR must ship the pure-Rust classifier
AND working `apr` CLI wiring AND at least one end-to-end test (assert_cmd
or subprocess) in the same commit.
Rationale: classifier-only (PARTIAL_ALGORITHM_LEVEL-only) PRs produce
well-documented empty promises — specs rot, follow-ups never land, users
can't reach the feature. Toyota Way: a PR that doesn't pass value
downstream to a real user hasn't completed.
- 4 merge gates (g1 classifier green; g2 CLI reachable; g3 e2e runs;
g4 contract discharged).
- 3 declared exceptions (BLOCKER-UPSTREAM-MISSING, BLOCKER-FIXTURE-ABSENT,
BLOCKER-SPEC-OPEN) for when wiring genuinely can't land yet — blocker
id must appear in BOTH the PR body and the contract's
`full_discharge_blocked_on`.
- Forbidden blockers explicitly listed ("I'll do it in a follow-up PR"
is banned).
- Pre-2026-04-21 classifier-only PRs (C-15/16/17/22/23) grandfathered
via `crux-wireup-<id>` follow-up tickets.
pv validate: 0 errors, 0 warnings.
Ref: contracts/crux-competitive-research-ux-v1.yaml § shipping_discipline
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
shipping_discipline:section tocontracts/crux-competitive-research-ux-v1.yamlcodifying CRUX-SHIP-001: every CRUX PR must ship the pure-Rust classifier AND workingaprCLI wiring AND at least one end-to-end test in the same commit.Rationale (Toyota Way): classifier-only (PARTIAL_ALGORITHM_LEVEL-only) PRs produce well-documented empty promises — specs rot, follow-ups never land, users can't reach the feature. A classifier that proves an invariant in pure Rust but isn't reachable via
apris operationally useless.What changed
g1_classifier_green,g2_cli_reachable,g3_e2e_runs,g4_contract_discharged.BLOCKER-UPSTREAM-MISSING,BLOCKER-FIXTURE-ABSENT,BLOCKER-SPEC-OPEN) for when wiring genuinely can't land yet — blocker id must appear in BOTH the PR body and the contract'sfull_discharge_blocked_on.crux-wireup-<id>follow-up tickets.pv validate
Test plan
pv validate contracts/crux-competitive-research-ux-v1.yaml— 0/0🤖 Generated with Claude Code