fix(0.35.1): root facade feature passthroughs (cargo install aprender --features cuda)#1895
Merged
Merged
Conversation
…pdates Closes a packaging gap surfaced by post-publish dogfood: `cargo install aprender --features cuda` failed because root facade exposed only `cli` + `default`. Per memory/feedback_cuda_feature_footgun, --features cuda is the documented install for GPU users (20 vs 400 tok/s). This patch adds passthroughs that forward to apr-cli: cuda, cuda-batch, wgpu, inference, training, training-gpu, visualization, zram, xet, whisper, full Also bundles README housekeeping for the v0.35.x release pair: - Hiatus banner (3-month freeze through 2026-08-22) - v0.35.0 + v0.35.1 release callouts - Contract count drift fix (1151 → 1153, missed by #1894) - Updated Quick Start with --features cuda/full examples Only root facade bumps (0.35.0 → 0.35.1). Sub-crates stay at 0.35.0; aprender@0.35.1 depends on apr-cli@0.35.0 (no transitive churn). End-user impact: `cargo install aprender --features cuda` now works.
3110f10 to
7685e8a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Post-publish dogfood of v0.35.0 surfaced a packaging gap:
cargo install aprender --features cudafails because the root facade only exposescli+default. Per memory/feedback_cuda_feature_footgun,--features cudais the documented install command for GPU users (20 vs 400 tok/s on RTX 4090).Fix
Add 11 passthrough features to root Cargo.toml that forward to apr-cli/*:
Versioning
0.35.0 → 0.35.10.35.0aprender@0.35.1depends onapr-cli@0.35.0(no transitive churn)aprenderneeds republishing to crates.ioEnd-user impact
After v0.35.1 lands on crates.io, both of these will work:
Verification
cargo metadataregisters all 11 new features ✓cargo checkparses correctly ✓🤖 Generated with Claude Code