contract(trace-moe-gpu-sub-stages-v1): v1.5.0 → v1.6.0 — FALSIFY-MOE-SUB-004 DISCHARGED#1531
Merged
Merged
Conversation
…SUB-004 DISCHARGED
Status promotion amendment: FALSIFY-MOE-SUB-004 PROPOSED → DISCHARGED.
Rule: "The M-GPU-MOE-1.4 fix PR title/body MUST mention one of:
{moe_router, moe_expert_gate, moe_expert_up, moe_expert_swigl,
moe_expert_out, moe_ffn_out}."
Discharge evidence: aprender PR #1529 squash 89cb26a (M85) title
is "fix(M-GPU-MOE-1.4 step c): qtype-aware dispatch in
expert_swiglu_cuda — closes L6 moe_ffn_out NaN" — explicitly cites
`moe_ffn_out` (one of the 6 enumerated stages) by name. The PR body
further cites "moe_ffn_out at layer 6" multiple times in the
Five-Whys analysis and per-layer bisection result table.
All four FALSIFY-MOE-SUB-* tests now DISCHARGED:
- SUB-001 (parse): DISCHARGED at v1.4.0 (M82)
- SUB-002 (byte-identity / heavy harness): DISCHARGED at v1.5.0 (M83)
- SUB-003 (bisection-pinpoints-stage): DISCHARGED at v1.5.0 (M83)
- SUB-004 (fix-PR-cites-stage): DISCHARGED at v1.6.0 (this amendment)
M-MOE-SUB-4 (per-expert sub-stages) stays PENDING — was optional;
M-MOE-SUB-3's MoeRouter+MoeFfnOut precision was sufficient for
M85's fix.
YAML-only — production hot paths byte-unchanged.
`pv validate` 0/0.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Status promotion amendment: FALSIFY-MOE-SUB-004 PROPOSED → DISCHARGED.
Rule
Discharge evidence
aprender PR #1529 squash
89cb26af7(M85) title:→ explicitly cites
moe_ffn_out(one of the 6 enumerated stages). The PR body further cites "moe_ffn_out at layer 6" multiple times in the Five-Whys analysis and per-layer bisection result table.All four FALSIFY-MOE-SUB-* tests now DISCHARGED
M-MOE-SUB-4 stays PENDING
The contract's
M-MOE-SUB-4(per-expert sub-stages) was always optional — "only needed if MoeRouter+MoeFfnOut bisection is insufficient precision". M85's fix landed without it; M-MOE-SUB-3's precision was sufficient. M-MOE-SUB-4 remains a future enhancement if M-GPU-MOE-3 cosine-refinement work needs to bisect the ~7-8 cos<0.99 layers (L7, L9, L12, L20, L23, L29, L46) at per-expert granularity.Test plan
pv validate0/0🤖 Generated with Claude Code