fix(compute): widen matvec_associativity tolerance (f32 SIMD flake)#1007
Merged
Conversation
…bling Flake surfaced in PR #987 workspace-test run 24782269410 — f32 SIMD rounding produced diff=0.01074 at max_val=0.854, exceeding the 1e-2 small-value tolerance. The sibling test_vecmat_associativity already uses 2e-2 uniformly (proptest_properties.rs:252). This aligns the matvec branch to match. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
aprender-compute::matrix::tests::property_tests::test_matvec_associativitysurfaced in PR feat(crux-e-02): perplexity classifier + apr ppl CLI (5 of 6 FALSIFY FULL, 1 of 6 PARTIAL; blocked on BLOCKER-UPSTREAM-MISSING) #987 workspace-test (run 24782269410)diff=0.01074atmax_val=0.854, exceeding the1e-2small-value tolerancetest_vecmat_associativityalready uses2e-2uniformly (proptest_properties.rs:252) — this aligns the matvec branch to matchTest plan
cargo test -p aprender-compute --lib test_matvec_associativitypasses locally (verified at seed cc 98ae51e21dd895b2e09ede9c321a2c1f1c024ec8650ed35b5b6b6466f9540077)🤖 Generated with Claude Code