Added data file for test with benbalter/jekyll-remote-theme#66
Open
mgerzabek wants to merge 1 commit intopages-themes:masterfrom
Open
Added data file for test with benbalter/jekyll-remote-theme#66mgerzabek wants to merge 1 commit intopages-themes:masterfrom
mgerzabek wants to merge 1 commit intopages-themes:masterfrom
Conversation
|
Welcome! Congrats on your first pull request to the Primer theme. If you haven't already, please be sure to check out the contributing guidelines. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upcoming releases of Jekyll will be able to read data files from within themes (see PR). Another pending PR will enable reading data files from remote themes.
To make a positive test for the latter I will need a
_datafolder within the Primer theme. So I do propose to include a minimal sample to be able to enhance the tests at https://github.com/benbalter/jekyll-remote-theme.