Skip to content

feat: check already running by lock file#871

Merged
b00f merged 4 commits intopactus-project:mainfrom
jkcs:feat/pactus-lock
Dec 26, 2023
Merged

feat: check already running by lock file#871
b00f merged 4 commits intopactus-project:mainfrom
jkcs:feat/pactus-lock

Conversation

@jkcs
Copy link
Copy Markdown
Contributor

@jkcs jkcs commented Dec 22, 2023

Description

Briefly describe the changes introduced by this pull request.

Referenced this #855 (comment)

Related issue(s)

If this Pull Request is related to an issue, mention it here.

@codecov
Copy link
Copy Markdown

codecov bot commented Dec 22, 2023

Codecov Report

Merging #871 (49759fe) into main (960a6a3) will increase coverage by 0.09%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #871      +/-   ##
==========================================
+ Coverage   83.22%   83.31%   +0.09%     
==========================================
  Files         170      170              
  Lines        8554     8554              
==========================================
+ Hits         7119     7127       +8     
+ Misses       1096     1090       -6     
+ Partials      339      337       -2     

Copy link
Copy Markdown
Contributor

@amirvalhalla amirvalhalla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please resolve requested changes.

@b00f
Copy link
Copy Markdown
Collaborator

b00f commented Dec 24, 2023

@jkcs Thanks. It is exactly what we were looking for.

Co-authored-by: b00f <mostafa.sedaghat@gmail.com>
@themantre
Copy link
Copy Markdown
Contributor

Please don't merge it till releasing version 0.18.2

@b00f b00f merged commit acd4462 into pactus-project:main Dec 26, 2023
@b00f
Copy link
Copy Markdown
Collaborator

b00f commented Dec 26, 2023

@kehiy Please test this PR on Windows
@amirvalhalla Please test this PR on MacOS

@b00f
Copy link
Copy Markdown
Collaborator

b00f commented Dec 26, 2023

@jkcs , Thanks for contributing to Pactus. We hope to see more of you on Pactus. The main goal of the bounty program is to find talented developers like you. If you're interested, you can join the Pactus development team. Please join our Discord server, as we have more discussions about core development there: https://discord.gg/H5vZkNnXCu

@jkcs
Copy link
Copy Markdown
Contributor Author

jkcs commented Dec 26, 2023

@b00f Thank you for the invitation. I have just joined.

@kehiy
Copy link
Copy Markdown
Contributor

kehiy commented Dec 26, 2023

@b00f it's merged, still need to be tested on the windows?

@b00f
Copy link
Copy Markdown
Collaborator

b00f commented Dec 27, 2023

it's merged, still need to be tested on the windows?
Yes please. Just run node twice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Resource temporarily unavailable

5 participants