Merged
Conversation
There's a subtle lifetime issue created in the original code. The original code uses: - `Bytes::from(&'static [u8])` - `from_raw_parts<'a, T>(*const T, usize) -> &'a [T]` Which requires the `*const T` pointer be a static pointer. Being provided through the FFI, this is unreasonable, and we should expect it to last only as long as the function call itself. By simply replacing `Bytes::from` with `Bytes::from_from_slice`, we narrow down the lifetime from `'static` to `'a`, allowing for the underlying `*const T` pointer to be deallocated once the function has returned. Signed-off-by: JP-Ellis <josh@jpellis.me>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There's a subtle lifetime issue created in the original code. The original code uses:
Bytes::from(&'static [u8])from_raw_parts<'a, T>(*const T, usize) -> &'a [T]Which requires the
*const Tpointer be a static pointer. Being provided through the FFI, this is unreasonable, and we should expect it to last only as long as the function call itself.By simply replacing
Bytes::fromwithBytes::from_from_slice, we narrow down the lifetime from'staticto'a, allowing for the underlying*const Tpointer to be deallocated once the function has returned.