Skip to content

Groundwork API for Provider#575

Merged
JP-Ellis merged 3 commits intomasterfrom
feat/verifier-groundwork
Mar 11, 2024
Merged

Groundwork API for Provider#575
JP-Ellis merged 3 commits intomasterfrom
feat/verifier-groundwork

Conversation

@JP-Ellis
Copy link
Copy Markdown
Contributor

@JP-Ellis JP-Ellis commented Feb 29, 2024

📝 Summary

Groundwork to be able to verifier HTTP pacts.

🚨 Breaking Changes

🔥 Motivation

Part of the work for V3

🔨 Test Plan

CI Workflow

🔗 Related issues/PRs

@JP-Ellis JP-Ellis added type:feature New feature area:core Relating to the core Pact Python library labels Feb 29, 2024
@JP-Ellis JP-Ellis self-assigned this Feb 29, 2024
@JP-Ellis JP-Ellis marked this pull request as ready for review March 8, 2024 04:08
@JP-Ellis JP-Ellis changed the title chore(ffi): implement verifier handle Groundwork API for Provider Mar 8, 2024
@JP-Ellis JP-Ellis force-pushed the feat/verifier-groundwork branch from 1141835 to dc46f08 Compare March 8, 2024 04:16
@JP-Ellis
Copy link
Copy Markdown
Contributor Author

JP-Ellis commented Mar 8, 2024

The FFI implies that the verifier is the core entity; though I am still on the fence whether I should call the class Verifier or Provider. Given that a verifier only ever has a single provider (though I guess a provider may have multiple verifiers), it might be more intuitive to rename the class.

@JP-Ellis JP-Ellis force-pushed the feat/verifier-groundwork branch from dc46f08 to 807d663 Compare March 8, 2024 04:31
Signed-off-by: JP-Ellis <josh@jpellis.me>
Signed-off-by: JP-Ellis <josh@jpellis.me>
These tests are purely meant to detect any issues with the FFI and
changes in any of the verifier methods.

The compatibility suite will ensure that the verifier is functioning
correctly.

Signed-off-by: JP-Ellis <josh@jpellis.me>
@JP-Ellis JP-Ellis force-pushed the feat/verifier-groundwork branch from 807d663 to 6d753bb Compare March 11, 2024 07:53
@JP-Ellis JP-Ellis merged commit 97bbf76 into master Mar 11, 2024
@JP-Ellis JP-Ellis deleted the feat/verifier-groundwork branch March 11, 2024 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:core Relating to the core Pact Python library type:feature New feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Groundwork API for Provider API using Rust backend

1 participant