Conversation
With the upgrade to the Pact FFI library, it is now possible to set matching rules directly during the Pact definition. These will be leveraged during the `v2` compatibility suite tests. Signed-off-by: JP-Ellis <josh@jpellis.me>
As most of the BDD steps are shared across the V1 and V2 suites, all of
the steps have been migrated into a shared module. Due to the way
PyTest-BDD inserts and resolves these steps, the general pattern of:
```python
def outer(stacklevel: int=1):
@when/given/then(..., stacklevel=stacklevel + 1)
def _():
...
```
is required; otherwise, the steps are not available.
This commit also includes the addition of a Markdown table parser, and a
few minor changes in preparation to the V2 suite (as this commit was
created following the implementation of the full V2 consumer suite).
Signed-off-by: JP-Ellis <josh@jpellis.me>
Signed-off-by: JP-Ellis <josh@jpellis.me>
24a21ef to
af128f6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Summary
This consists of two main changes:
with_matching_rulesto theInteraction. This allows for matching rules to be explicitly given, without the need to pass the matching rule JSON format to one of the otherwith_*functions.v2/consumercompatibility suite, which makes use of the newwith_matching_rules.🚨 Breaking Changes🔥 Motivation
Another step towards the compatibility suite being implemented
🔨 Test Plan
Compatibility suite, as part of CI/CD
🔗 Related issues/PRs
v2/http_consumer.feature#474