chore(tests): add generators to interaction defn#1217
Merged
Conversation
Signed-off-by: JP-Ellis <josh@jpellis.me>
Signed-off-by: JP-Ellis <josh@jpellis.me>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements generators-related compatibility test suites for Pact, adding support for V3 and V4 generator functionality. It extends the interaction definition system to handle generators in addition to existing matching rules.
- Added generator support to the
InteractionDefinitionclass for both request and response - Renamed
parse_matching_rulestoparse_rulesto handle both matching rules and generators - Implemented comprehensive test suites for V3 and V4 generator features
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
tests/compatibility_suite/util/interaction_definition.py |
Extended interaction definition to support generators and refactored rule parsing |
tests/compatibility_suite/util/__init__.py |
Renamed function from parse_matching_rules to parse_rules for broader usage |
tests/compatibility_suite/test_v4_generators.py |
New comprehensive test suite for V4 generator functionality |
tests/compatibility_suite/test_v3_generators.py |
New comprehensive test suite for V3 generator functionality |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Signed-off-by: JP-Ellis <josh@jpellis.me>
2c3fb2e to
8fb18b4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Summary
Implement the generators-related compatibility suite.
🚨 Breaking Changes🔥 Motivation
🔨 Test Plan
🔗 Related issues/PRs