Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements compatibility test suites for both V3 and V4 matching rules to ensure proper compatibility across Pact specifications. The tests validate various matcher types including array contains, each value, semver, status code, and other matching rules with both positive and negative test cases.
Key changes:
- Adds comprehensive V3 matching rules test suite with support for boolean, content type, date/time, values, and other matchers
- Implements V4 matching rules test suite including newer matchers like ArrayContains, EachValue, and semver matchers
- Provides shared test infrastructure for request/response comparison and mismatch validation
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| tests/compatibility_suite/test_v4_matching_rules.py | Complete V4 matching rules test implementation with fixtures, scenario definitions, and step implementations |
| tests/compatibility_suite/test_v3_matching_rules.py | Complete V3 matching rules test implementation with similar structure but V3-specific matcher support |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Summary
Implement compatibility suites around matching rules.
🚨 Breaking Changes
🔥 Motivation
🔨 Test Plan
🔗 Related issues/PRs