Skip to content

Add Maven support for purl2url#177

Merged
tdruez merged 8 commits intopackage-url:mainfrom
fafanoulele:main
Jun 5, 2025
Merged

Add Maven support for purl2url#177
tdruez merged 8 commits intopackage-url:mainfrom
fafanoulele:main

Conversation

@fafanoulele
Copy link
Contributor

@fafanoulele fafanoulele commented Jan 21, 2025

Add Maven support e.g.:

> purl2url.get_repo_url("pkg:maven/org.apache.commons/commons-io@1.3.2")
"https://repo1.maven.org/maven2/org/apache/commons/commons-io/1.3.2"

> purl2url.get_download_url("pkg:maven/org.apache.commons/commons-io@1.3.2")
"https://repo1.maven.org/maven2/org/apache/commons/commons-io/1.3.2/commons-io-1.3.2.jar"

@robertguetzkow robertguetzkow mentioned this pull request Feb 8, 2025
Closed
@pombredanne
Copy link
Member

pombredanne commented Feb 11, 2025

@fafanoulele Thanks. The thing may be a bit more complex for JARs because of the many "artefacts" available for a given version....

@pombredanne
Copy link
Member

pombredanne commented Feb 11, 2025

See also #179 (comment)

pombredanne
pombredanne requested changes Feb 11, 2025
View reviewed changes
Copy link
Member

@pombredanne pombredanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. Here is some feedback for your consideration.

@pombredanne
Copy link
Member

pombredanne commented Feb 11, 2025

You may also want to check this by @robertguetzkow aboutcode-org/dejacode#256 (comment)

I would also suggest using resolved URLs as the basis when they are already included in the SBOM and identifiable, instead of relying on purl2url which might not work for every package manager.

@fafanoulele
Copy link
Contributor Author

fafanoulele commented Feb 17, 2025

@fafanoulele Thanks. The thing may be a bit more complex for JARs because of the many "artefacts" available for a given version....

I've added support for type and classifier as qualifiers e.g.:

> purl2url.get_download_url("pkg:maven/org.apache.commons/commons-io@1.3.2?type=pom")
"https://repo1.maven.org/maven2/org/apache/commons/commons-io/1.3.2/commons-io-1.3.2.pom"

> purl2url.get_download_url("pkg:maven/org.apache.commons/commons-io@1.3.2?classifier=arbitrary")
"https://repo1.maven.org/maven2/org/apache/commons/commons-io/1.3.2/commons-io-1.3.2-arbitrary.jar"

tdruez
tdruez approved these changes Jun 5, 2025
View reviewed changes
Copy link
Collaborator

@tdruez tdruez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fafanoulele Thanks for this contribution! I've made a few simplifications.
Ready for merge!

@tdruez tdruez merged commit c42e618 into package-url:main Jun 5, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pombredanne pombredanne pombredanne requested changes

@tdruez tdruez tdruez approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@fafanoulele @pombredanne @tdruez