style: pipe operator for union type hints#173
Merged
tdruez merged 1 commit intopackage-url:mainfrom Oct 31, 2024
Merged
Conversation
Signed-off-by: Jonathan Howard <jonathan.w.howard@lmco.com>
Contributor
Author
|
@tdruez @gruebel Here's the follow-on PR for what we discussed in this comment |
tdruez
approved these changes
Oct 31, 2024
Member
|
the pipe syntax is not available before python v8.10 does this change cause no issues? I mean, the lint/mypy might not properly detect - they run in py3.9 -- I would at least expect that build-and-test CI/CT detects issues running on py3.8.tested: $ docker run --rm -it --entrypoint python python:3.8.0 -c "
from typing import Union
AnyStr = Union[str, bytes]
def normalize_type(type: AnyStr | None, encode: bool | None = True) -> str | None:
pass
"
Traceback (most recent call last):
File "<string>", line 4, in <module>
TypeError: unsupported operand type(s) for |: '_GenericAlias' and 'NoneType' |
Contributor
Author
|
@jkowalleck try also adding |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates union type annotations to use the PEP-604 pipe operator, changing type hints like this:
to this:
The changes were auto-generated by running
pyupgrade --py38-plus src/packageurl/__init__.py. It switches to using built-in typesdictandtuplerather thantyping.Dictandtyping.Tuple.Miscellaneous
sourceryassign-if-exp: replace if statements, e.g.:avoid-builtin-shadow: don't assign to builtin variabletype(renames local variabletypetotype_inPackageURL.from_string())ruffRUF010: Use explicit conversion flag (change instances off"{repr(value)}"tof"{value!r}")