fix: Ensure first load of "with replies" tab starts from the top#2308
Merged
nikclayton merged 1 commit intoMay 27, 2026
Merged
Conversation
Previous code didn't attempt position restoration unless the loaded page snapshot contained the status ID to restore to. This doesn't work if there is no position (i.e., the status ID to restore to is null). Practically, this meant the account screen's "with replies" tab was loading somewhere in the middle of the first page of statuses. Fix this, by: 1. Explicitly filtering out updates where the snapshot is empty (can't restore position in an empty snapshot). 2. Explicitly set the position to restore to 0 if the status ID is null. Fixes pachli#2236
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous code didn't attempt position restoration unless the loaded page snapshot contained the status ID to restore to.
This doesn't work if there is no position (i.e., the status ID to restore to is null).
Practically, this meant the account screen's "with replies" tab was loading somewhere in the middle of the first page of statuses.
Fix this, by:
Fixes #2236