fix: Displays mentions as links when the mention URL doesn't match#2263
Merged
Conversation
To resolve mentions Pachli compares the `a.href` of the link to the `mention.url` properties in the status. If it doesn't match the previous code was returning null from `getCustomSpanForMention`. This removed the `URLSpan` from the mention, rendering it unlinked. Fallback to `MaybeUnderlineURLSpan` in this case, so the mention is still clickable. It will almost certainly open the account in the user's browser (because the search to lookup the account will probably fail) but this is better than it not being clickable, and matches the behaviour of the web UI. Reported by @badnetmask@hachyderm.io, @ozoned@btfree.social
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To resolve mentions Pachli compares the
a.hrefof the link to themention.urlproperties in the status.If it doesn't match the previous code was returning null from
getCustomSpanForMention. This removed theURLSpanfrom the mention, rendering it unlinked.Fallback to
MaybeUnderlineURLSpanin this case, so the mention is still clickable. It will almost certainly open the account in the user's browser (because the search to lookup the account will probably fail) but this is better than it not being clickable, and matches the behaviour of the web UI.Reported by @badnetmask@hachyderm.io, @ozoned@btfree.social