fix: Encode user content that looks like HTML for display#2245
Merged
Conversation
Some user content (e.g., display names, pronouns, filter titles) might contain HTML characters (e.g., "</Antir>"). If these are passed through `fromHtml` the content is corrupted, and in some cases disappears. For example, in the string "</Antir> boosted" for boosted posts the `</Antir>` text disappears. Fix this by calling `htmlEncode()` on user generated content before it is passed to `htmlHtml`. Reported by https://github.com/anauta in pachli#2180
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some user content (e.g., display names, pronouns, filter titles) might contain HTML characters (e.g., ""). If these are passed through
fromHtmlthe content is corrupted, and in some cases disappears.For example, in the string " boosted" for boosted posts the
</Antir>text disappears.Fix this by calling
htmlEncode()on user generated content before it is passed tohtmlHtml.Reported by https://github.com/anauta in #2180