fix: Don't crash when removing tabs#2206
Merged
Merged
Conversation
Removing a tab notified the adapter that tabs 0..tabs.size had changed, but tabs.size was the new size, not the old size. So deleting a tab from the end could cause the adapter to assume the previous end tab was still present. Fix that by calling `notifyDataSetChanged()`. To guard against the tab selection listener being called with a tab position that no longer exists, use `getOrNull` to fetch the tab data, ignoring the case when the tab does not exist.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removing a tab notified the adapter that tabs 0..tabs.size had changed, but tabs.size was the new size, not the old size. So deleting a tab from the end could cause the adapter to assume the previous end tab was still present. Fix that by calling
notifyDataSetChanged().To guard against the tab selection listener being called with a tab position that no longer exists, use
getOrNullto fetch the tab data, ignoring the case when the tab does not exist.