feat: Show out-of-band-hashtags at the end of the content#2130
Merged
Conversation
A status might contain one or more out-of-band-hashtags; hashtags included by the account that created the status but that are not part of the content in the status. Piefed, for example, allows these to be created. Previously these hashtags were not shown, which could cause user confusion when a status appears in their timeline without an obvious reason -- the user was following the hashtag but the hashtag wasn't visible. Make these hashtags visible by displaying them in a new paragraph at the end of the content.
any more. Update call sites for linkListener rename
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A status might contain one or more out-of-band-hashtags; hashtags
included by the account that created the status but that are not part
of the content in the status. Piefed, for example, allows these to be
created.
Previously these hashtags were not shown, which could cause user
confusion when a status appears in their timeline without an obvious
reason -- the user was following the hashtag but the hashtag wasn't
visible.
Make these hashtags visible by displaying them in a new paragraph at
the end of the content (if present).
Re-write and rename
SetStatusContentto do this. The refactoringsubsumes the old
setClickableTextfunction, so this also means thatMarkdown rendering (if enabled) will work in all places that used
to call this. Chiefly, that's account bios.
Hashtags now have to be normalised the same way Mastodon does,
handled in
HashtagNormaliser.kt. This replaces the existingAsciiFolding.kt.Fixes #1551