Swift Shift/src/Constants.swift:1

• [nitpick] If IGNORE_APP_BUNDLE_ID is intended to remain unchanged, consider declaring it as a constant using 'let' instead of 'var' to enhance immutability and clarity.

var IGNORE_APP_BUNDLE_ID = [

Swift Shift/src/View/IgnoredAppsTabView.swift (4)

54-58: Consider making the list height responsive.

The list view has a fixed height of 200 points, which might be too small when many apps are added or too large for smaller displays. Consider making this responsive to the content size or window size constraints.

-        .frame(height: 200)
+        .frame(minHeight: 100, idealHeight: 200, maxHeight: 300)

---

102-105: Consider app state preservation.

The code activates the app to bring the NSOpenPanel to the front, which is generally good practice. However, this might disrupt user focus in some edge cases. Consider adding a comment explaining this design choice and potential alternatives.

// Activate the app first to ensure its windows are in front
NSApp.activate(ignoringOtherApps: true)

// Use runModal for sheet-style presentation that will come to the front
+// Note: Using runModal instead of beginSheet to ensure dialog appears properly
+// This approach may briefly disrupt user focus but ensures reliable panel presentation
let response = openPanel.runModal()

---

41-41: Improve handling of missing app names.

When displaying app items, if the app name isn't resolved, the code falls back to showing the bundle identifier, which isn't very user-friendly. Consider improving how unresolved app names are displayed.

-Text(appNames[bundleId] ?? bundleId)
+Text(appNames[bundleId] ?? bundleId.components(separatedBy: ".").last?.capitalized ?? bundleId)

---

79-91: Add documentation for methods.

The code would benefit from documentation comments for methods to explain their purpose and behavior, particularly for methods that interact with system APIs or handle preferences.

+/// Loads both default and user-defined ignored apps from preferences
+/// and resolves their bundle identifiers to human-readable app names
private func loadApps() {
    defaultIgnoredApps = IGNORE_APP_BUNDLE_ID
    ignoredApps = PreferencesManager.getUserIgnoredApps()
    
    // Resolve bundle IDs to app names
    for bundleId in (defaultIgnoredApps + ignoredApps) {
        if let appURL = NSWorkspace.shared.urlForApplication(withBundleIdentifier: bundleId),
           let appBundle = Bundle(url: appURL),
           let appName = appBundle.object(forInfoDictionaryKey: "CFBundleName") as? String {
            appNames[bundleId] = appName
        }
    }
}

Swift Shift/src/Manager/Preferences.swift (4)

8-8: Fix redundant string enum value.

The string value for the ignoredApps case is redundant as Swift will automatically use the case name when it matches. Consider removing the explicit raw value to address the SwiftLint warning.

-    case ignoredApps = "ignoredApps"
+    case ignoredApps

🧰 Tools

🪛 SwiftLint (0.57.0)

[Warning] 8-8: String enum values can be omitted when they are equal to the enumcase name

(redundant_string_enum_value)

---

16-22: Consider using Set for efficiency.

The getIgnoredApps() method creates a Set to remove duplicates and then converts back to an Array. If this list is accessed frequently, consider returning a Set directly or caching the result to avoid repeated conversions.

static func getIgnoredApps() -> [String] {
    // Include default apps + user-added apps
    if let savedApps = UserDefaults.standard.array(forKey: PreferenceKey.ignoredApps.rawValue) as? [String] {
-        return Array(Set(IGNORE_APP_BUNDLE_ID + savedApps)) // Ensure no duplicates
+        // Cache the combined list for better performance
+        let combinedList = Array(Set(IGNORE_APP_BUNDLE_ID + savedApps))
+        return combinedList
    }
    return IGNORE_APP_BUNDLE_ID
}

---

16-57: Consider encapsulating IGNORE_APP_BUNDLE_ID.

The code directly accesses IGNORE_APP_BUNDLE_ID which appears to be a global constant. Consider encapsulating this within the PreferencesManager class for better maintainability.

+// Add this property to the PreferencesManager class
+static private let defaultIgnoredApps = IGNORE_APP_BUNDLE_ID

static func getIgnoredApps() -> [String] {
    // Include default apps + user-added apps
    if let savedApps = UserDefaults.standard.array(forKey: PreferenceKey.ignoredApps.rawValue) as? [String] {
-        return Array(Set(IGNORE_APP_BUNDLE_ID + savedApps)) // Ensure no duplicates
+        return Array(Set(defaultIgnoredApps + savedApps)) // Ensure no duplicates
    }
-    return IGNORE_APP_BUNDLE_ID
+    return defaultIgnoredApps
}

// Update other methods similarly

---

36-44: Add validation for bundle identifiers.

Consider adding validation to ensure that added bundle identifiers conform to the expected format, which typically follows reverse-domain notation (e.g., "com.example.app").

static func addIgnoredApp(_ bundleId: String) {
+    // Validate bundle ID format (basic check for reverse domain notation)
+    guard bundleId.contains(".") && !bundleId.hasPrefix(".") && !bundleId.hasSuffix(".") else {
+        NSLog("Invalid bundle identifier format: \(bundleId)")
+        return
+    }
+    
    var currentList = getUserIgnoredApps()
    
    // Don't add apps that are already in default list
    if !IGNORE_APP_BUNDLE_ID.contains(bundleId) && !currentList.contains(bundleId) {
        currentList.append(bundleId)
        setUserIgnoredApps(currentList)
    }
}

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro