Skip to content
This repository was archived by the owner on Jul 23, 2025. It is now read-only.

feat(core): Support Windows#666

Merged
paambaati merged 60 commits intomainfrom
gp/windows-support
May 7, 2023
Merged

feat(core): Support Windows#666
paambaati merged 60 commits intomainfrom
gp/windows-support

Conversation

@paambaati
Copy link
Copy Markdown
Owner

BREAKING CHANGE: Support Windows, now that CodeClimate has released a Windows binary of the reporter – see https://codeclimate.com/changelog/7dd79ee1cf1af7141b2bd18b

Fixes #665.

@paambaati paambaati added the enhancement New feature or request label Apr 24, 2023
@paambaati paambaati self-assigned this Apr 24, 2023
@paambaati
Copy link
Copy Markdown
Owner Author

Currently blocked by qltysh-archive/test-reporter#517, but I will continue updating tests.

@paambaati
Copy link
Copy Markdown
Owner Author

paambaati commented May 6, 2023

At this point, all tests technically should pass on CI, but for some weird reason, all failing tests are because of string comparison failures – when really, the strings do match.

See tape-testing/tape#593

paambaati and others added 5 commits May 7, 2023 10:25
See tape-testing/tape#593 (comment)

Looks like inside Windows (NTFS), all paths are case insensitive. The Windows laptop I used reported the default path as 'C:\WINDOWS', while the CI machine reports it as 'C:\Windows'
@paambaati paambaati marked this pull request as ready for review May 7, 2023 05:16
Verified that major, minor and patch tags all work now
@paambaati paambaati merged commit f0efca8 into main May 7, 2023
@paambaati paambaati deleted the gp/windows-support branch May 7, 2023 05:36
@paambaati
Copy link
Copy Markdown
Owner Author

🎉 This PR is included in version 5.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

enhancement New feature or request released

Projects

None yet

Development

Successfully merging this pull request may close these issues.

could we add windows support?

1 participant