Skip to content

Use Python venv in CI tests#219

Merged
jafingerhut merged 1 commit into
p4lang:mainfrom
jafingerhut:use-venv-in-ci-testing
Mar 6, 2025
Merged

Use Python venv in CI tests#219
jafingerhut merged 1 commit into
p4lang:mainfrom
jafingerhut:use-venv-in-ci-testing

Conversation

@jafingerhut

Copy link
Copy Markdown
Collaborator

Without this, I have seen many failures recently on Ubuntu 22.04 that I do not know the root cause of, but using a venv gives consistently passing results.

Without this, I have seen many failures recently on Ubuntu 22.04 that
I do not know the root cause of, but using a venv gives consistently
passing results.

Signed-off-by: Andy Fingerhut <andy_fingerhut@alum.wustl.edu>

@antoninbas antoninbas left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, but I think you should consider using https://github.com/actions/setup-python as a follow up. This way you can control which version of python to test with (you can add multiple versions to the test matrix as well). I'm assuming Python-based projects which use Github Actions for testing typically use this core action to set up the environment.

@jafingerhut

Copy link
Copy Markdown
Collaborator Author

you should consider using https://github.com/actions/setup-python as a follow up. This way you can control which version of python to test with (you can add multiple versions to the test matrix as well). I'm assuming Python-based projects which use Github Actions for testing typically use this core action to set up the environment.

Thanks. I will create an issue with your suggestion, to track it for future implementation, but merge this PR as is.

@jafingerhut jafingerhut merged commit 8e0fdf8 into p4lang:main Mar 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants