Add a send timeout to nnpy sockets.#183
Merged
antoninbas merged 4 commits intop4lang:mainfrom Jun 13, 2023
Merged
Conversation
antoninbas
reviewed
Jun 13, 2023
Member
antoninbas
left a comment
There was a problem hiding this comment.
I haven't tested this, but the change LGTM
antoninbas
approved these changes
Jun 13, 2023
Contributor
Author
|
Thanks! Possible to also push a new version of the pypi package? Then I can use it in the corresponding p4c PR. |
Member
Done |
Contributor
Author
Great, thanks for the quick update. |
8 tasks
This was referenced Jun 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the nanomsg peer has crashed or is otherwise non-functional, nanomsg will block indefinitely on send. This PR adds a socket option with a (conservative) timeout.
Fixes #178.