[#4365] [#4907] Add test cases related to issue #4365#5175
Conversation
Signed-off-by: Kyle Cripps <kyle@pensando.io>
ChrisDodd
left a comment
There was a problem hiding this comment.
Looks good.
For future work, maybe make @command_line errors not trigger the full command line help message?
@ChrisDodd I don't think that's related to
|
It's related to command line processing -- the help list occurs whenever there is an error from that. We probably want to be more sparing in general, as that help list is large and causes the actual error message to scroll off the screen. Mostly just an annoyance, however. |
I agree, I often run into this problem and the error message gets completely lost in the help output. |
#5123 made it very easy to add tests for functionality that is dependent on command-line options, so this PR does that and adds the following test cases:
--Wdisableor--Wwarnto demote errors. Allow--Winfo=diagnosticto work fordiagnostics that can be both warnings and errors. #4366)--Wdisabletakes precedence over--Werrorfor warnings (Allow--Wdisableto take precedence over--Werrorfor warning messages #4894)This also closes #4907.