Skip to content

Update p4tc's iproute2 to v17-rc8#5172

Merged
jafingerhut merged 1 commit into
p4lang:mainfrom
vbnogueira:update-p4tc-iproute2
Mar 10, 2025
Merged

Update p4tc's iproute2 to v17-rc8#5172
jafingerhut merged 1 commit into
p4lang:mainfrom
vbnogueira:update-p4tc-iproute2

Conversation

@fruffy

@fruffy fruffy commented Mar 10, 2025

Copy link
Copy Markdown
Collaborator

Opening on behalf of @vbnogueira.

Fixes #5171 temporarily.

@fruffy fruffy added p4tc Topics related to the P4-TC back end. On PRs, also triggers p4tc CI tests to run. infrastructure Topics related to code style and build and test infrastructure. labels Mar 10, 2025
@vbnogueira vbnogueira force-pushed the update-p4tc-iproute2 branch 3 times, most recently from a28f114 to e2733e3 Compare March 10, 2025 15:35
Signed-off-by: Victor Nogueira <victor@mojatatu.com>
@vbnogueira vbnogueira force-pushed the update-p4tc-iproute2 branch from e2733e3 to 71e49b6 Compare March 10, 2025 16:02
@jafingerhut

Copy link
Copy Markdown
Contributor

@vbnogueira If you approve of these changes, please say so in a comment.

@ChrisDodd @vlstill If one or both of you can also approve (or suggest someone else to review it that can approve), I can go ahead and merge this. I say that not because I understand the details of the changes, but because it is passing all CI tests, which is a clear improvement over the current state of affairs. I am assuming that if any further related changes are desired, hopefully they will only affect the p4tc backend tests, not the other backend tests.

@ChrisDodd ChrisDodd left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it should not affect anything non-tc related

@vlstill vlstill left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks safe for the rest of the compiler to me.

@jafingerhut

Copy link
Copy Markdown
Contributor

Given that this is blocking everyone's p4c CI testing, I am going to merge this given Chris Dodd's review, and the fact that it is passing all CI tests. If there are problems that result from this merging, they are on my head, but I'm thinking positively right now :-)

@jafingerhut jafingerhut added this pull request to the merge queue Mar 10, 2025
Merged via the queue into p4lang:main with commit d7c0805 Mar 10, 2025
@vbnogueira vbnogueira deleted the update-p4tc-iproute2 branch March 18, 2025 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

infrastructure Topics related to code style and build and test infrastructure. p4tc Topics related to the P4-TC back end. On PRs, also triggers p4tc CI tests to run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Build broken because of dead link (p4tc)

5 participants