Update p4tc CI tests to run on Ubuntu 22.04#5168
Conversation
Signed-off-by: Andy Fingerhut <andy.fingerhut@gmail.com>
Signed-off-by: Andy Fingerhut <andy.fingerhut@gmail.com>
Signed-off-by: Andy Fingerhut <andy.fingerhut@gmail.com>
|
@vbnogueira Please take a look at this PR's changes, too, and see if you approve. Ubuntu 20.04 will no longer be supported on Github CI runs by April 1. 2025. See #5155 for context. Thus running tests on Ubuntu 22.04 will soon be necessary for the test to be run at all. |
vlstill
left a comment
There was a problem hiding this comment.
Giving this a green mark even though I am not familiar with p4tc -- given the approval of @vbnogueira and that the CI def file changes make sense :-).
Please just rename the PR before merging.
| runs-on: ubuntu-20.04 | ||
| test-ubuntu-p4tc-stf: | ||
| # Only run on pull requests with the "run-p4tc" label. | ||
| if: ${{ github.event_name == 'schedule' || contains(github.event.pull_request.labels.*.name, 'run-p4tc') }} |
There was a problem hiding this comment.
I am not sure an extra label makes sense here. We already have p4tc and the test should be triggered by this label.
I am also planning to add a trigger that the tests are triggered by any change in the p4tc folder.
There was a problem hiding this comment.
commit 4 changes label triggering runs back to 'p4tc'
Signed-off-by: Andy Fingerhut <andy.fingerhut@gmail.com>
|
All tests pass after rebasing. Several approvals, so merging. |
No description provided.