Skip to content

Updated the no start state error message to include only parser name#5164

Merged
vlstill merged 1 commit into
p4lang:mainfrom
psivanup:psivanup/no-start-err-msg
Mar 7, 2025
Merged

Updated the no start state error message to include only parser name#5164
vlstill merged 1 commit into
p4lang:mainfrom
psivanup:psivanup/no-start-err-msg

Conversation

@psivanup

@psivanup psivanup commented Mar 5, 2025

Copy link
Copy Markdown
Contributor

No description provided.

@psivanup psivanup force-pushed the psivanup/no-start-err-msg branch from 4fe3fbb to 585f0a6 Compare March 5, 2025 06:59

@maheswari-s maheswari-s left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine

@psivanup psivanup marked this pull request as ready for review March 5, 2025 08:45
@fruffy fruffy added bmv2 Topics related to BMv2 or v1model core Topics concerning the core segments of the compiler (frontend, midend, parser) and removed bmv2 Topics related to BMv2 or v1model labels Mar 5, 2025

@vlstill vlstill left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm little surprised the error line is not broken by the use of name only. I guess the parser should always fill source info even for names so it should be OK.

Comment thread frontends/p4/validateParsedProgram.h Outdated
@psivanup psivanup force-pushed the psivanup/no-start-err-msg branch from 585f0a6 to 097b41d Compare March 6, 2025 14:41
Signed-off-by: Pitchumani Sivanupandi <pitchumani.sivanupandi@intel.com>
Comment thread frontends/p4/validateParsedProgram.h
@psivanup

psivanup commented Mar 7, 2025

Copy link
Copy Markdown
Contributor Author

Thanks @maheswari-s, @vlstill , @fruffy and @ChrisDodd for the review.
Can someone merge this PR if it is fine?

@vlstill vlstill added this pull request to the merge queue Mar 7, 2025
@vlstill

vlstill commented Mar 7, 2025

Copy link
Copy Markdown
Member

Queued for merge.

Merged via the queue into p4lang:main with commit 8991c29 Mar 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core Topics concerning the core segments of the compiler (frontend, midend, parser)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants