Skip to content

Bazel build: use Clang and bump rules_foreign and protobuf versions.#5148

Merged
smolkaj merged 1 commit into
mainfrom
bzlmod
Feb 25, 2025
Merged

Bazel build: use Clang and bump rules_foreign and protobuf versions.#5148
smolkaj merged 1 commit into
mainfrom
bzlmod

Conversation

@smolkaj

@smolkaj smolkaj commented Feb 25, 2025

Copy link
Copy Markdown
Member

This is is preparation for migrating to Bzlmod ( #5066), which requires up-to-date versions of all dependencies.

This is is preparation for migrating to Bzlmod ( #5066), which requires
up-to-date versions of all dependencies.

Signed-off-by: Steffen Smolka <smolkaj@google.com>
Comment thread .bazelrc
common --noenable_bzlmod

build --action_env=BAZEL_CXXOPTS="-std=c++17"
# Use C++17.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will have the same problem as #4640 where every dependency needs to set those options, right?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that's true.

@smolkaj smolkaj added this pull request to the merge queue Feb 25, 2025
@fruffy fruffy added the infrastructure Topics related to code style and build and test infrastructure. label Feb 25, 2025
Merged via the queue into main with commit d4365f1 Feb 25, 2025
@smolkaj smolkaj deleted the bzlmod branch February 25, 2025 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

infrastructure Topics related to code style and build and test infrastructure.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants