Remove some unnecessary imports of Scapy module#5128
Merged
jafingerhut merged 3 commits intoFeb 18, 2025
Conversation
Signed-off-by: Andy Fingerhut <andy_fingerhut@alum.wustl.edu>
jafingerhut
commented
Feb 17, 2025
|
|
||
| from bmv2stf import Options, RunBMV2 | ||
| from scapy.layers.all import * | ||
| from scapy.utils import * |
Contributor
Author
There was a problem hiding this comment.
I have tried to find any mentions of Scapy names from this file, but have not found any. Unfortunately it is difficult to be 100% certain with from <module> import *, because they could be anywhere in the file without having the module name in front of them.
In the git commit history for run-bmv2-test.py, I found that back in 2016 there were some uses of rdpcap and Ether symbols from scapy in this file, but al of those were removed by 2016 or 2017, thus it appears that these import statements are vestigial.
Signed-off-by: Andy Fingerhut <andy_fingerhut@alum.wustl.edu>
fruffy
approved these changes
Feb 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.