Add a bf-asm command line option in addition to environment variables.#5070
Merged
Conversation
Contributor
Sure |
b0ab3d5 to
57daa92
Compare
jafingerhut
approved these changes
Dec 17, 2024
jafingerhut
left a comment
Contributor
There was a problem hiding this comment.
LGTM. The proof is in the build & successful test pudding, of course, but I'm betting this is getting us closer.
Signed-off-by: fruffy <fruffy@nyu.edu>
57daa92 to
0f64f6f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@pkotikal Can you try whether this option works. I do not have a machine with the studio available currently.