Use a version of simple switch that uses nanomsg instead of virtual interfaces for PTF tests.#3951
Merged
Use a version of simple switch that uses nanomsg instead of virtual interfaces for PTF tests.#3951
Conversation
dad6f54 to
2099f15
Compare
2099f15 to
950855c
Compare
Contributor
|
What is the motivation for such a change? Is it that since veth interfaces are no longer required for packets into and out of simple_switch, that PTF tests can be run without root privileges? |
Collaborator
Author
There are three advantages to this approach.
The downside is that we are not "emulating" real network conditions anymore. However, for testing the tool chain I would say nanomsg is sufficient. And we can make this a toggle option for the script (either run veth or nanomsg). |
fd31b1f to
6d1b610
Compare
62651ed to
fc278c4
Compare
fc278c4 to
137f7d1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for nanomsg to the
run-bmv2-ptf-test.pyscript. It does not yet add support to create a large number of ports. The behavior of the script is the same as the veth interfaces for now.