check free space and pause decode instead of failing#258
Merged
harrypm merged 5 commits intooyvindln:vhs_decodefrom Jan 20, 2026
Merged
check free space and pause decode instead of failing#258harrypm merged 5 commits intooyvindln:vhs_decodefrom
harrypm merged 5 commits intooyvindln:vhs_decodefrom
Conversation
…too, so we might fill up the disk in between the checks otherwise
Collaborator
|
After testing this, the decoding impact time is only a couple seconds, given this safeguarding feature can save hours of re-running things, this is probably one of the most useful additions I've ever seen. This should be added to HiFi-Decode and CVBS-Decode and upstream ld-decode ideally too. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This happens often enough to me that I wrote a fix for it: running out of space leaving an unusable partial decode, and running out of space with multiple decodes in parallel results in all of them being unusable.
This adds a free space check that pauses decoding until more than 10GB of space is available (again).
Performance impact is minimal because it's only done every 500 fields (after the first 100).