Improve fallback_vsync to handle fields with partly corrupted hsync area#192
Merged
oyvindln merged 5 commits intooyvindln:vhs_decodefrom Mar 15, 2025
Merged
Improve fallback_vsync to handle fields with partly corrupted hsync area#192oyvindln merged 5 commits intooyvindln:vhs_decodefrom
oyvindln merged 5 commits intooyvindln:vhs_decodefrom
Conversation
… and line0 belong to same position and increased tolerance to pulse distances
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This improves the
get_line0_fallbackfunction used by --fallback_vsync to use some more tricks to find the line0 pulse: It will not only consider pulse length, but also pulse distance to detect different parts of the blanking area. The old method (just return last vsync pulse before a long pulse) is the last fallback when the more advanced methods do not work.Additionally
get_line0_fallbackwill also detect field type and determine how confident the field type detection is and return these values. Those are passed toget_first_hsync_locthat will use them if either confidence ofget_line0_fallbackis very high or if there was no previous field detected