Skip to content

Sync / Field order fixes#176

Merged
oyvindln merged 2 commits intooyvindln:vhs_decodefrom
eshaz:single-vblank-sync
Dec 14, 2024
Merged

Sync / Field order fixes#176
oyvindln merged 2 commits intooyvindln:vhs_decodefrom
eshaz:single-vblank-sync

Conversation

@eshaz
Copy link
Copy Markdown

@eshaz eshaz commented Dec 11, 2024

Fixes

  • Only sync on a fully validated vblanking interval (i.e. top vblank, hsync lines, bottom vblank, should have the expected distances before syncing, otherwise, use the estimated sync position)
    • Fixes edge case where damaged VHS (not fallback-vsync) causes either the first or second vblank to improperly be detected and the sync to jump.
  • Only change field order if syncing on validated vblanking interval; otherwise, use opposite of previous frame.
    • Prevents duplicate field orders from being detected when vblanking area is damaged

@eshaz eshaz marked this pull request as draft December 13, 2024 10:59
@eshaz eshaz marked this pull request as ready for review December 13, 2024 11:53
@oyvindln oyvindln merged commit 3eb60fe into oyvindln:vhs_decode Dec 14, 2024
@eshaz eshaz deleted the single-vblank-sync branch March 8, 2025 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants